RFR: 8330159: [C2] Remove or clarify Compile::init_start [v5]

[Tobias Hartmann]

On Mon, 2 Sep 2024 11:10:35 GMT, Yagmur Eren <duke at openjdk.org> wrote:

>> Compile::init_start method contained only an assertion. To cleanup, this method is removed and the locations where this method is called are replaced with the corresponding assertion. See issue: [JDK-8330159](https://bugs.openjdk.org/browse/JDK-8330159)
>
> Yagmur Eren has updated the pull request incrementally with one additional commit since the last revision:
> 
>   adding NOT_DEBUG_RETURN instead of DEBUG_ONLY for Compile::verify_start

src/hotspot/share/opto/compile.cpp line 1109:

> 1107: 
> 1108: #ifdef ASSERT
> 1109: // Install the StartNode on this compile object.

I think this comment needs to be updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20715#discussion_r1741754226