RFR: 8338023: Support two vector selectFrom API [v7]
Emanuel Peter
epeter at openjdk.org
Tue Sep 3 12:15:32 UTC 2024
On Fri, 30 Aug 2024 14:02:46 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Adding descriptive comments
>
> src/hotspot/cpu/x86/x86.ad line 10490:
>
>> 10488:
>> 10489:
>> 10490: instruct selectFromTwoVec_evex(vec dst, vec src1, vec src2)
>
> You could rename `dst` -> `mask_and_dst`. That would maybe help the reader to more quickly know that it is an input-mask and output-dst.
Also, for consistency, I would write out the name `selectFromTwoVector(s)_evex`
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20508#discussion_r1741772354
More information about the hotspot-compiler-dev
mailing list