RFR: 8330159: [C2] Remove or clarify Compile::init_start [v5]

Tobias Hartmann thartmann at openjdk.org
Tue Sep 3 13:30:25 UTC 2024


On Tue, 3 Sep 2024 12:39:52 GMT, Yagmur Eren <duke at openjdk.org> wrote:

>> src/hotspot/share/opto/compile.cpp line 1109:
>> 
>>> 1107: 
>>> 1108: #ifdef ASSERT
>>> 1109: // Install the StartNode on this compile object.
>> 
>> I think this comment needs to be updated.
>
> I believe the following may sound good briefly?: "Verify that the current StartNode is valid."

Sounds good to me.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20715#discussion_r1742065594


More information about the hotspot-compiler-dev mailing list