RFR: 8335444: Generalize implementation of AndNode mul_ring [v3]
Jasmine Karthikeyan
jkarthikeyan at openjdk.org
Tue Sep 3 18:20:20 UTC 2024
On Tue, 3 Sep 2024 14:39:45 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> Jasmine Karthikeyan has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Check IR before macro expansion
>
> I think there are still quite a few unaddressed review comments above, so I'll hold off with reviewing myself. Feel free to ping me if you need another review.
@eme64 I was thinking that this PR and the associated IR tests could serve as a baseline for future future work in this area, such as #17508, since it just uses the signed bounds we already have to do its analysis. My goal was to make the changes as simple as possible, so that we can see some benefits short term while we work on the long-term solution for better type inference. Originally I just had the `[0..C]` case since I saw that it showed up a lot in real-world code, but I kept finding generalizations and eventually it snowballed 😅
-------------
PR Comment: https://git.openjdk.org/jdk/pull/20066#issuecomment-2327144025
More information about the hotspot-compiler-dev
mailing list