RFR: 8315066: Add unsigned bounds and known bits to TypeInt/Long [v7]
Quan Anh Mai
qamai at openjdk.org
Tue Sep 3 20:39:41 UTC 2024
On Tue, 3 Sep 2024 13:58:06 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> src/hotspot/share/opto/rangeinference.cpp line 109:
>>
>>> 107: static AdjustResult<KnownBits<T>>
>>> 108: adjust_bits_from_bounds(const KnownBits<T>& bits, const RangeInt<T>& bounds) {
>>> 109: static_assert(std::is_unsigned<T>::value, "");
>>
>> Again: could be a member function of `KnownBits`, where unsigned could be verified already...
>
> At any rate, I would name `T -> U`
Yes I have renamed all signed types to `S` and unsigned types to `U`. Regarding making it a member of `KnownBits`, making it a `static` function has the advantage of visibility to me.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17508#discussion_r1742658774
More information about the hotspot-compiler-dev
mailing list