RFR: 8315066: Add unsigned bounds and known bits to TypeInt/Long [v7]

Vladimir Kozlov kvn at openjdk.org
Tue Sep 3 22:59:21 UTC 2024


On Tue, 3 Sep 2024 20:49:40 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

>> What are your thoughts on how we are going to debug-print the new int-type? We probably do not always want to print the KnownBits, in general that is way too verbose. But in some alignment example, it would be nice to know that it is the `int/long` range, but the lowest 3 bits are always zero, hence 8 byte aligned.
>
> @eme64 Thanks a lot for your reviews, I think I have addressed all of them, I will add some more explicit tests tomorrow. Regarding the `dump`, I made a new method `dump_verbose` which would dump the bit information of the type. What do you think? Also, the test failures are due to the `int:>=0` is now dumped differently (`int:0..max_int ^ 0..max_int`). Do you think it would be more suitable to make the type dumping more clever or to modify existing tests?

@merykitty
Can you add JMH benchmark which shows benefits of these changes?
Does this change affect C2 compilation speed? It seems we may spend more time in `Value()` methods and other places where we create new type.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17508#issuecomment-2327580747


More information about the hotspot-compiler-dev mailing list