RFR: 8339299: C1 will miss type profile when inline final method [v3]

Dean Long dlong at openjdk.org
Wed Sep 4 01:53:22 UTC 2024


On Sat, 31 Aug 2024 00:17:03 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Yes, exactly.
>
> I am not sure how Dean proposal will help. I agree with Vladimir's suggestion - C1 should not optimize call sites in Level 3 compilation.

I was just trying to think how to preserve the original intend of this code, which seemed to be "skip profiling if the profiling info is not needed", but getting it right seems complicated, so I'm OK with always doing it.

> C1 should not optimize call sites in Level 3 compilation.

You mean don't use can_be_statically_bound() and other checks to devirtualize virtual calls?  I believe C1 does that at all compilation levels.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20786#discussion_r1742883560


More information about the hotspot-compiler-dev mailing list