RFR: 8338924: C1: assert(0 <= i && i < _len) failed: illegal index 5 for length 5 [v2]

[Tobias Hartmann]

On Tue, 3 Sep 2024 15:03:56 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> The change in [JDK-8335664](https://bugs.openjdk.org/browse/JDK-8335664) caused a crash when initializing basic blocks with `-Xcomp`. This change introduces a check to see if JSR is the last bytecode in its method so that expected behavior matches the previous patch. Verified with tier 1-6 tests.
>
> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Vladimir and Tobias comments

Looks good to me otherwise.

src/hotspot/share/c1/c1_GraphBuilder.cpp line 1393:

> 1391:   // has already been activated. Watch for this case and bail out.
> 1392:   if (next_bci() >= method()->code_size()) {
> 1393:       // This can happen if the subroutine does not terminate with a ret,

Indentation is incorrect here (should be 2 whitespace instead of 4).

-------------

Marked as reviewed by thartmann (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20732#pullrequestreview-2279064608
PR Review Comment: https://git.openjdk.org/jdk/pull/20732#discussion_r1743116302