RFR: 8338971: IGV: Add incrementally inlined method name to phase name [v2]

[Christian Hagedorn]

On Tue, 3 Sep 2024 13:26:32 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> Christian Hagedorn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   suggestion
>
> src/hotspot/share/opto/compile.cpp line 5206:
> 
>> 5204:         call->method()->print_short_name(&ss);
>> 5205:       }
>> 5206:     }
> 
> Suggestion: using `call->_name` instead of `call->method()->print_short_name()` is slightly simpler and more general (should be equivalent for incremental inlining, but will also print stub names, "uncommon trap", etc. when dumping `PHASE_AFTER_ITER_GVN_STEP` graphs on call nodes).
> Suggestion:
> 
>     ss.print(": %d %s", n->_idx, NodeClassNames[n->Opcode()]);
>     if (n->is_Call()) {
>       CallNode* call = n->as_Call();
>       if (call->_name != nullptr) {
>         ss.print(" - %s", call->_name);
>       }
>     }

Thanks for the suggestion. I think `_name` is only set if there is no attached method. So, we could combine your suggestion with what I've had. What do you think? (see pushed update)

This gives us:

![image](https://github.com/user-attachments/assets/33aad438-432a-4252-8e5b-c75220491bf5)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20834#discussion_r1743117370