RFR: 8332461: ubsan : dependencies.cpp:906:3: runtime error: load of value 4294967295, which is not a valid value for type 'DepType'

[Stefan Karlsson]

On Wed, 4 Sep 2024 07:04:36 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

> The error mentioned in the JBS issue is seen on x86_64 as well as on s390x during the build, with `--enable-ubsan` configuration. 
> 
> I have added `-1` to enum to fix this issue for now as mentioned by @MBaesken. But removing the assert itself is also a possible solution, mentioned on the JBS issue. 
> 
> So I will happy to follow the reviews/suggestion if this is not a good fix.

Shouldn't this new enum value also be used in the place that sets DepType to -1?:

  _type       = (DepType)(end_marker-1);  // defeat "already at end" assert

(An alternative could be to find another way to defeat the "already at end" assert, but I guess that's out-of-scope for this PR)

-------------

Changes requested by stefank (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20847#pullrequestreview-2279453632