Integrated: 8336860: x86: Change integer src operand for CMoveL of 0 and 1 to long

[Jasmine Karthikeyan]

On Mon, 22 Jul 2024 03:33:23 GMT, Jasmine Karthikeyan <jkarthikeyan at openjdk.org> wrote:

> Hi all,
> This patch fixes `cmovL_imm_01*` instructions matching against an integer immediate 1 instead of a long immediate 1. I noticed while looking at the backend implementation of CMove that the rules specify `immI_1` instead of `immL1`, which means that the instructions can't be matched and instead falls through to the base case. I added a small benchmark and got these results:
> 
>                                         Baseline                     Patch           Improvement
> Benchmark                Mode  Cnt    Score   Error  Units      Score   Error  Units
> BasicRules.cmovL_imm_01  avgt   15  259.073 ± 5.806  ns/op    231.108 ± 2.730  ns/op  (+ 11.41%)
> 
> Thoughts and reviews would be appreciated!

This pull request has now been integrated.

Changeset: 6f8714ee
Author:    Jasmine Karthikeyan <jkarthikeyan at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/6f8714ee197eb48923209299fd842f6757f0a945
Stats:     109 lines in 4 files changed: 105 ins; 0 del; 4 mod

8336860: x86: Change integer src operand for CMoveL of 0 and 1 to long

Reviewed-by: epeter, chagedorn, shade, qamai, jbhateja

-------------

PR: https://git.openjdk.org/jdk/pull/20275