RFR: 8337753: Target class of upcall stub may be unloaded [v3]

Amit Kumar amitkumar at openjdk.org
Wed Sep 4 16:49:27 UTC 2024


On Wed, 4 Sep 2024 16:45:04 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> src/hotspot/cpu/s390/stubGenerator_s390.cpp line 3062:
>> 
>>> 3060:     StubCodeMark mark(this, "StubRoutines", "upcall_stub_load_target");
>>> 3061:     address start = __ pc();
>>> 3062:     __ save_return_pc();
>> 
>> @offamitkumar: Is saving and restoring the return_pc needed? Isn't in preserved by load_heap_oop?
>
> I looked into it, but couldn't find out. But I remove the `save_return_pc` & `restore_return_pc` and everything seems fine. So maybe we can remove it.

Tier1 test are fine with/without "saving & restoring" return_pc;

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20479#discussion_r1744117640


More information about the hotspot-compiler-dev mailing list