RFR: 8332461: ubsan : dependencies.cpp:906:3: runtime error: load of value 4294967295, which is not a valid value for type 'DepType' [v2]

Stefan Karlsson stefank at openjdk.org
Thu Sep 5 07:11:55 UTC 2024


On Thu, 5 Sep 2024 02:59:06 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   initialise with undefined_dependency
>
> src/hotspot/share/code/dependencies.hpp line 107:
> 
>> 105:   enum DepType {
>> 106:     // _type is initially set to -1, to prevent "already at end" assert
>> 107:     undefined_dependency = -1,
> 
> Preserving the existing value seems fine, though it appears any value >= TYPE_LIMIT would work just as well.

FWIW, I was also entertaining the idea of a solution like that with the hope that it would fit better with the usage in the iterators.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20847#discussion_r1744921838


More information about the hotspot-compiler-dev mailing list