RFR: 8338100: C2: assert(!n_loop->is_member(get_loop(lca))) failed: control must not be back in the loop [v3]
Roland Westrelin
roland at openjdk.org
Thu Sep 5 13:21:19 UTC 2024
On Tue, 3 Sep 2024 07:58:25 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:
>> Roland Westrelin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains nine additional commits since the last revision:
>>
>> - remove useless PhaseIdealLoop::only_has_infinite_loops()
>> - Merge branch 'master' into JDK-8338100
>> - Update src/hotspot/share/opto/loopnode.hpp
>>
>> Co-authored-by: Tobias Hartmann <tobias.hartmann at oracle.com>
>> - Update src/hotspot/share/opto/loopnode.cpp
>>
>> Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
>> - Update src/hotspot/share/opto/loopnode.cpp
>>
>> Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
>> - comment
>> - test fix
>> - remove verification code
>> - test & fix
>
> Looks reasonable to me.
@chhagedorn @TobiHartmann thanks for the reviews. I took care of the comments in the new commits.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/20797#issuecomment-2331662706
More information about the hotspot-compiler-dev
mailing list