RFR: 8335444: Generalize implementation of AndNode mul_ring [v3]
Jasmine Karthikeyan
jkarthikeyan at openjdk.org
Fri Sep 6 04:41:24 UTC 2024
On Wed, 4 Sep 2024 06:09:06 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:
>> Jasmine Karthikeyan has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Check IR before macro expansion
>
> I agree that we should keep this RFE simple. And we are just using thing that we already have. So, we could just go with the optimizations that you currently have (if you like to apply the few simple improvement suggestions, you can already do that) and follow up with future RFEs to cover more cases.
@chhagedorn I've pushed a new version that should address all the comments from code review. I ended up handling the case with two negative ranges as well because it didn't add too much code complexity, but I agree that we should just use the optimizations we have and not add more to this PR.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/20066#issuecomment-2333218988
More information about the hotspot-compiler-dev
mailing list