RFR: 8315066: Add unsigned bounds and known bits to TypeInt/Long [v16]

[Vladimir Kozlov]

On Sun, 8 Sep 2024 05:07:59 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

>> Hi,
>> 
>> This patch adds unsigned bounds and known bits constraints to TypeInt and TypeLong. This opens more transformation opportunities in an elegant manner as well as helps avoid some ad-hoc rules in Hotspot.
>> 
>> In general, a TypeInt/Long represents a set of values x that satisfies: x s>= lo && x s<= hi && x u>= ulo && x u<= uhi && (x & zeros) == 0 && (~x & ones) == 0. These constraints are not independent, e.g. an int that lies in [0, 3] in signed domain must also lie in [0, 3] in unsigned domain and have all bits but the last 2 being unset. As a result, we must normalize the constraints (tighten the constraints so that they are optimal) before constructing a TypeInt/Long instance.
>> 
>> This is extracted from #15440 , node value transformations are left for later PRs. I have also added unit tests to verify the soundness of constraint normalization.
>> 
>> Please kindly review, thanks a lot.
>> 
>> Testing
>> 
>> - [x] GHA
>> - [x] Linux x64, tier 1-4
>
> Quan Anh Mai has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 23 commits:
> 
>  - change (~v & ones) == 0 to (v & ones) == ones
>  - Merge branch 'master' into unsignedbounds
>  - fix builds
>  - add trivial test cases
>  - make should return the correct type
>  - rename tests
>  - more explanation
>  - fix build
>  - fix build
>  - add more comments, group KnownBits
>  - ... and 13 more: https://git.openjdk.org/jdk/compare/5b72bbf9...9b70213e

Good.

Please, also update PR's description.

You need second approval.

-------------

Marked as reviewed by kvn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17508#pullrequestreview-2288574407
PR Comment: https://git.openjdk.org/jdk/pull/17508#issuecomment-2336759364