RFR: 8339714: Delete tedious bool type define

Julian Waters jwaters at openjdk.org
Mon Sep 9 13:06:07 UTC 2024


On Mon, 9 Sep 2024 12:56:56 GMT, SendaoYan <syan at openjdk.org> wrote:

>> src/utils/hsdis/binutils/hsdis-binutils.c line 67:
>> 
>>> 65: #include "hsdis.h"
>>> 66: 
>>> 67: #ifndef bool
>> 
>> I'm a little worried about this change. hsdis may really need an int here. If that turns out to not be the case then I'll retract my concerns
>
> I have verified this change locally, include build hsdis.so and check the functional with command java -XX:+UnlockDiagnosticVMOptions -XX:+PrintAssembly -version. The verified show this change for hsdis.so work normally.

Ok, sounds good

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20909#discussion_r1750222067


More information about the hotspot-compiler-dev mailing list