RFR: 8315066: Add unsigned bounds and known bits to TypeInt/Long [v7]

Quan Anh Mai qamai at openjdk.org
Tue Sep 10 12:23:29 UTC 2024


On Wed, 4 Sep 2024 08:25:19 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Yes I have renamed all signed types to `S` and unsigned types to `U`. Regarding making it a member of `KnownBits`, making it a `static` function has the advantage of visibility to me.
>
> What do you mean by "advantage of visibility"?

I mean it is only used in `rangeinference.cpp` while `KnownBits` can be accessed from other places as well. And updating a `KnownBits` according to a `RangeInt` seems local to the context of `TypeInt` canonicalization.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17508#discussion_r1751841702


More information about the hotspot-compiler-dev mailing list