RFR: 8315066: Add unsigned bounds and known bits to TypeInt/Long [v15]

Quan Anh Mai qamai at openjdk.org
Tue Sep 10 12:23:29 UTC 2024


On Sat, 7 Sep 2024 01:19:56 GMT, Jasmine Karthikeyan <jkarthikeyan at openjdk.org> wrote:

>> Quan Anh Mai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix builds
>
> src/hotspot/share/opto/rangeinference.cpp line 470:
> 
>> 468:   // Neither contains each other, weird?
>> 469:   // fatal("Integer value range is not subset");
>> 470:   // return this;
> 
> This looks like leftover dead code.

Yes it is, but I don't want to remove it. I think it should be the case the `new_type` contains `old_type`, but apparently sometimes it is not the case and I don't understand it. Returning the bottom type instead of `limit_type` is also weird, too.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17508#discussion_r1751837343


More information about the hotspot-compiler-dev mailing list