RFR: 8315066: Add unsigned bounds and known bits to TypeInt/Long [v13]
Quan Anh Mai
qamai at openjdk.org
Tue Sep 10 12:30:11 UTC 2024
On Thu, 5 Sep 2024 16:59:02 GMT, Jasmine Karthikeyan <jkarthikeyan at openjdk.org> wrote:
>> Quan Anh Mai has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - rename tests
>> - more explanation
>
> I think in most cases we expect `TypeInteger::make()` to have well-defined inputs and thus well-defined outputs, so I also think it would be good to keep the use sites as they were before for code cleanliness. For places where TOP is allowed there could be another function, maybe `TypeInteger::try_make()`, to signal explicitly that TOP is being handled by the callee code.
@jaskarth Thanks a lot for your reviews and suggestions, I hope I have addressed all of them.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17508#issuecomment-2340577178
More information about the hotspot-compiler-dev
mailing list