RFR: 8332442: C2: refactor Mod cases in Compile::final_graph_reshaping_main_switch() [v3]

Kangcheng Xu kxu at openjdk.org
Tue Sep 10 16:21:48 UTC 2024


On Tue, 10 Sep 2024 16:08:21 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Kangcheng Xu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
>> 
>>  - Merge branch 'openjdk:master' into refactor-mod-cases
>>  - include aarch64 in tests, add more configuration combinations
>>  - remove redundant arguments, test with -XX:-UseDivMod
>>  - Merge branch 'master' into refactor-mod-cases
>>  - Add test and IRNode for signed int/long divmod
>>  - created IR tests
>>  - passing tier1 tests
>>  - refactor divmod ops to handle_div_mod_op
>
> test/hotspot/jtreg/compiler/c2/TestDivModNodes.java line 38:
> 
>> 36:  * @run main/othervm -XX:+UseDivMod compiler.c2.TestDivModNodes
>> 37:  * @run main/othervm -XX:-UseDivMod compiler.c2.TestDivModNodes
>> 38:  */
> 
> Drive by comment: please allow it to run on any platform, and add restrictions on whee the IR rules are run. That allows us to test results on other platforms, which is valuable on its own.

Done. Waiting GHA to complete

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20877#discussion_r1752275174


More information about the hotspot-compiler-dev mailing list