RFR: 8329035: New Data Destination instructions support [v5]

[Steve Dohrmann]

On Wed, 11 Sep 2024 19:25:15 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Steve Dohrmann has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits:
>> 
>>  - Merge master
>>  - remove instr. functions based on review comments
>>  - refactoring and fixes based on review comments
>>  - function name changes based on review comments
>>  - fix 32-bit build name errors, missing no_flags arg, and addw functions
>>  - 8329035: New Data Destination instructions support
>
> src/hotspot/cpu/x86/assembler_x86.cpp line 7496:
> 
>> 7494:   emit_arith(0x33, 0xC0, src1, src2);
>> 7495: }
>> 7496: 
> 
> We just removed `xorw(reg, reg)` because it is not used: [#20901](https://git.openjdk.org/jdk/pull/20901)
> Please, don't add it back.

Sorry.  Done.

> src/hotspot/cpu/x86/assembler_x86.hpp line 796:
> 
>> 794:   void evex_prefix_ndd(Address adr, int ndd_enc, int xreg_enc, VexSimdPrefix pre, VexOpcode opc, InstructionAttr *attributes, bool no_flags = false);
>> 795: 
>> 796:   void evex_prefix_nf(Address adr, int ndd_enc, int xreg_enc, VexSimdPrefix pre, VexOpcode opc, InstructionAttr *attributes, bool no_flags = false);
> 
> May be split these lines.

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20698#discussion_r1755785250
PR Review Comment: https://git.openjdk.org/jdk/pull/20698#discussion_r1755785161