RFR: 8333258: C2: high memory usage in PhaseCFG::insert_anti_dependences() [v5]
Emanuel Peter
epeter at openjdk.org
Thu Sep 12 08:41:13 UTC 2024
On Thu, 12 Sep 2024 08:06:05 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> Roland Westrelin has updated the pull request incrementally with one additional commit since the last revision:
>>
>> more review
>
> src/hotspot/share/opto/gcm.cpp line 761:
>
>> 759:
>> 760: uint op = use_mem_state->Opcode();
>> 761: assert(!use_mem_state->needs_anti_dependence_check(), "only stores");
>
> The comment in the assert is misleading. It can also be MergeMem, Phi, etc
Maybe say `only MergeMem and state modifying nodes`. Or just `no loads`?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19791#discussion_r1756356201
More information about the hotspot-compiler-dev
mailing list