RFR: 8337221: CompileFramework: test library to conveniently compile java and jasm sources for fuzzing

[Emanuel Peter]

On Tue, 30 Jul 2024 07:26:27 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> @lepestock Why exactly is my solution not multi-threading safe?
>> Does your solution with `File.createTempFile` allow (easy) extraction of the generated files when there is a failure? Where could those files be found?
>
> BTW: in the IR-Framework, we also use `ProcessTools.getProcessId` to generate unique filenames. Would that also be an issue there? So far we have not seen problems with it though...

Thanks for the offline conversation. `ProcessTools.getProcessId` is per process. If there are multiple threads in one process, this leads to issues. Also if I use the `CompileFramework` repeatedly, this could lead to issues.

I think I can use `Files.createTempDirectory(Paths.get("."), "compile-framework-sources-");` to create a directory. "temp" does not mean it is necessarily deleted, only if I also use `File.deleteOnExit()`. So that should be ok, and the files are accessible if there is a failure.

I'm also thinking that I may need a temporary class-file directory. Otherwise, there could be issues if the `CompileFramework` is used repeatedly or in parallel. Currently, I just put them all in the `-Dtest.classes` dir, but that could lead to raise conditions.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20184#discussion_r1696502974