RFR: 8333258: C2: high memory usage in PhaseCFG::insert_anti_dependences() [v3]

Roland Westrelin roland at openjdk.org
Fri Sep 13 07:48:17 UTC 2024


On Tue, 23 Jul 2024 16:20:23 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Roland Westrelin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>> 
>>  - refactoring
>>  - Merge branch 'master' into JDK-8333258
>>  - review
>>  - Merge branch 'master' into JDK-8333258
>>  - whitespaces
>>  - tests & fix
>
> But I would like you to fix the comments here:
> 
>   // The relevant stores "nearby" the load consist of a tree rooted
>   // at initial_mem, with internal nodes of type MergeMem.
>   // Therefore, the branches visited by the worklist are of this form:
>   //    initial_mem -> (MergeMem ->)* store
>   // The anti-dependence constraints apply only to the fringe of this tree.
> 
> There are not just `MergeMem` but also `Phi` nodes.

@eme64 thanks for the review
@vnkozlov does this still look good to you?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19791#issuecomment-2348262038


More information about the hotspot-compiler-dev mailing list