RFR: 8339790: Support Intel APX setzucc instruction [v3]

Jatin Bhateja jbhateja at openjdk.org
Fri Sep 13 19:23:14 UTC 2024


On Fri, 13 Sep 2024 17:27:29 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Jatin Bhateja has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:
>> 
>>  - Review comments resolution.
>>  - Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8339790
>>  - Review resolutions.
>>  - 8339790: Support Intel APX setzucc instruction.
>
> src/hotspot/cpu/x86/gc/x/x_x86_64.ad line 129:
> 
>> 127:   format %{ "lock\n\t"
>> 128:             "cmpxchgq $newval, $mem\n\t"
>> 129:             "sete_with_zextl  $res\n\t" %}
> 
> Please, use `setcc` in format to match `ins_encode`.  `sete_with_zextl` isused only when it is supported.

Hi @vnkozlov ,
setcc used in inst_encoding block is a macro assembly routine which emits either setcc + movzbl or setzucc for APX supported targets, I wanted to use one opto instruction to correctly depict semantics of both the cases.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20920#discussion_r1759379552


More information about the hotspot-compiler-dev mailing list