Integrated: 8340102: Move assert-only loop in OopMapSort::sort under debug macro
Aleksey Shipilev
shade at openjdk.org
Mon Sep 16 05:35:16 UTC 2024
On Fri, 13 Sep 2024 10:04:01 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
> Found this papercut when looking at Leyden perf runs.
>
> In OopMapSort::sort, there is a loop that apparently is only there for asserts. At least GCC 11.4 apparently not smart enough to eliminate the whole loop in release builds, probably because iterator reads things from the stream. Wrapping the loop with #ifdef ASSERT saves about 144 bytes in code stream.
This pull request has now been integrated.
Changeset: 0e0f10f9
Author: Aleksey Shipilev <shade at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/0e0f10f95217b5caaed02744a0a341350e4f2bc7
Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod
8340102: Move assert-only loop in OopMapSort::sort under debug macro
Reviewed-by: stuefe, fyang, kvn
-------------
PR: https://git.openjdk.org/jdk/pull/20992
More information about the hotspot-compiler-dev
mailing list