RFR: 8337221: CompileFramework: test library to conveniently compile java and jasm sources for fuzzing [v3]

Christian Hagedorn chagedorn at openjdk.org
Mon Sep 16 10:32:07 UTC 2024


On Mon, 16 Sep 2024 09:26:22 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> test/hotspot/jtreg/compiler/lib/compile_framework/CompileFramework.java line 54:
>> 
>>> 52:                     File.pathSeparator +
>>> 53:                     classesDir.toAbsolutePath().toString();
>>> 54:         return cp.replace("\\", "\\\\"); // For windows paths
>> 
>> Is this really required and not automatically handled correctly by `Path` on Windows?
>
> I could also add this at the use-site. The problem is that I'm using it in the generated Java code as a String, and so there we have to escape the backslash. Without this, I got those mysterious timeouts on Windows.

Ah, I see. Maybe you can add a comment to clarify the reason behind.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20184#discussion_r1760894864


More information about the hotspot-compiler-dev mailing list