RFR: 8337221: CompileFramework: test library to conveniently compile java and jasm sources for fuzzing [v12]
Emanuel Peter
epeter at openjdk.org
Mon Sep 16 15:05:44 UTC 2024
On Mon, 16 Sep 2024 08:28:41 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:
>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>>
>> one more
>
> test/hotspot/jtreg/compiler/lib/compile_framework/CompileFramework.java line 206:
>
>> 204: } catch (Exception e) {
>> 205: throw new CompileFrameworkException("Could not create directory: " + dir.toString(), e);
>> 206: }
>
> Could be extracted to a method `ensureDirectoryExists()`. Same below (i.e. `writeToFile()`).
I think it is still small enough.... so I'd rather keep it like it is. Splitting it all up creates a lot of boiler plate.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20184#discussion_r1761332838
More information about the hotspot-compiler-dev
mailing list