RFR: 8332442: C2: refactor Mod cases in Compile::final_graph_reshaping_main_switch() [v7]
duke
duke at openjdk.org
Mon Sep 16 15:18:09 UTC 2024
On Wed, 11 Sep 2024 20:26:43 GMT, Kangcheng Xu <kxu at openjdk.org> wrote:
>> Hello all. This patch addresses [JDK-8332442](https://bugs.openjdk.org/browse/JDK-8332442) and refactors `Op_ModI`/`Op_ModL`/`Op_UModI`/`Op_UModL` cases in `DIVMOD` transforamtions. The purpose of the transformation to convert adjacent div `/` and mod `%` operations of the same operands into one should the platform support this feature (e.g., x86-64).
>>
>> I took the liberty adding _signed_ DIVMOD nodes (i.e., `DIV_MOD_I` and `DIV_MOD_L`) to the `IRNode` class constants as they are previously missing. Please let me know if they were left intentionally and if there are any other concerns. Thanks!
>>
>> ~This will be a draft PR before GHA tests are confirmed passing.~
>
> Kangcheng Xu has updated the pull request incrementally with one additional commit since the last revision:
>
> format comments, add @bug, avoid zero divisor
@tabjy
Your change (at version ef7882b0990532fccad167a274d06eacadf68407) is now ready to be sponsored by a Committer.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/20877#issuecomment-2353213354
More information about the hotspot-compiler-dev
mailing list