RFR: 8332442: C2: refactor Mod cases in Compile::final_graph_reshaping_main_switch() [v7]

Kangcheng Xu kxu at openjdk.org
Mon Sep 16 15:45:22 UTC 2024


On Mon, 16 Sep 2024 15:15:45 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Kangcheng Xu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   format comments, add @bug, avoid zero divisor
>
> test/hotspot/jtreg/compiler/c2/TestDivModNodes.java line 36:
> 
>> 34:  * @summary Test that DIV and MOD nodes are converted into DIVMOD where possible
>> 35:  * @library /test/lib /
>> 36:  * @requires vm.compiler2.enabled
> 
> Is `C2` really required for this test? Or could another compiler also benefit from your test?

Removed C2 requirements for validating arithmetic results on other compilers too

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20877#discussion_r1761393742


More information about the hotspot-compiler-dev mailing list