RFR: 8338023: Support two vector selectFrom API [v7]
Jatin Bhateja
jbhateja at openjdk.org
Tue Sep 17 07:10:54 UTC 2024
On Mon, 16 Sep 2024 07:27:44 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> Please at least add a comment why you are not following my suggestion. I feel like the work I put in to review is not being respected when comments are just silently resolved without any action or comment.
>
> I really do think that `as_ConI()` would be the right thing here. In product it is just a cast, and in debug at least we have an assert.
DONE
**It just got overlooked @eme64, we respect reviewer suggestions and value the time you invest in polishing our patches, thanks again :-)**
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20508#discussion_r1762504618
PR Review Comment: https://git.openjdk.org/jdk/pull/20508#discussion_r1762504671
More information about the hotspot-compiler-dev
mailing list