RFR: 8332442: C2: refactor Mod cases in Compile::final_graph_reshaping_main_switch() [v8]
Christian Hagedorn
chagedorn at openjdk.org
Tue Sep 17 07:22:22 UTC 2024
On Mon, 16 Sep 2024 15:45:21 GMT, Kangcheng Xu <kxu at openjdk.org> wrote:
>> Hello all. This patch addresses [JDK-8332442](https://bugs.openjdk.org/browse/JDK-8332442) and refactors `Op_ModI`/`Op_ModL`/`Op_UModI`/`Op_UModL` cases in `DIVMOD` transforamtions. The purpose of the transformation to convert adjacent div `/` and mod `%` operations of the same operands into one should the platform support this feature (e.g., x86-64).
>>
>> I took the liberty adding _signed_ DIVMOD nodes (i.e., `DIV_MOD_I` and `DIV_MOD_L`) to the `IRNode` class constants as they are previously missing. Please let me know if they were left intentionally and if there are any other concerns. Thanks!
>>
>> ~This will be a draft PR before GHA tests are confirmed passing.~
>
> Kangcheng Xu has updated the pull request incrementally with one additional commit since the last revision:
>
> remove C2 requirement for tests
Sorry for letting you wait! Yes, testing was clean.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/20877#issuecomment-2354733807
More information about the hotspot-compiler-dev
mailing list