RFR: 8337221: CompileFramework: test library to conveniently compile java and jasm sources for fuzzing [v13]

[Emanuel Peter]

On Tue, 17 Sep 2024 07:53:19 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   move some code around
>
> test/hotspot/jtreg/compiler/lib/compile_framework/CompileFramework.java line 59:
> 
>> 57:     }
>> 58: 
>> 59:     private String sourceCodesAsString(List<SourceCode> sourceCodes) {
> 
> Just a side node, since this is not C where you need to define the methods first and then use them, I suggest to do it the other way round: Define methods below as they are used. This makes it easier to read I think

Ok, I'll keep this in mind :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20184#discussion_r1763586020