RFR: 8338021: Support new unsigned and saturating vector operators in VectorAPI [v13]
Jatin Bhateja
jbhateja at openjdk.org
Wed Sep 18 16:26:13 UTC 2024
On Wed, 18 Sep 2024 14:22:16 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
> > > Do we have tests for the publically exposed methods in this new file? Or are they only implicitly tested through the VectorAPI, and its tests? `src/jdk.incubator.vector/share/classes/jdk/incubator/vector/VectorMath.java`
> > > Why is this even called `VectorMath`? Because those ops are not at all restricted to vectorization, right?
> >
> >
> > Nomenclature is suggested by Paul.
>
> @PaulSandoz Do you want to limit these **scalar** operations to a class name that implies **vector** use?
>
> > We have sufficient test coverage of these APIs in JTREG tests.
>
> @jatin-bhateja I can't see any dedicated JTREG tests to the `VectorMath` methods. I only see the VectorAPI tests. Can you point me to the `VectorMath` tests? I'd like to review them.
https://github.com/openjdk/jdk/pull/20507/files#diff-6031c9066a7d7a90cc002e93a1eb64f0371f09d385f42289d202426cc7516d2fR3019-R3264
-------------
PR Comment: https://git.openjdk.org/jdk/pull/20507#issuecomment-2358909462
More information about the hotspot-compiler-dev
mailing list