RFR: 8315066: Add unsigned bounds and known bits to TypeInt/Long [v21]
Emanuel Peter
epeter at openjdk.org
Thu Sep 19 15:26:48 UTC 2024
On Thu, 19 Sep 2024 15:13:36 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> src/hotspot/share/opto/rangeinference.cpp line 118:
>>
>>> 116: // have all lower bits being 0. This value satisfies zeros, because all
>>> 117: // bits before the first violation have already satisfied zeros, and all
>>> 118: // bits after the first violation are 0. To satisfy 1, simply | this value
>>
>> Suggestion:
>>
>> // bits after the first violation are 0. To satisfy ones, simply OR this value
>
> Ok, this I can understand much better!
Maybe you can even add a line like below, to visually describe the result of the math below:
`result = lo[>i], 1, ones[<i]`
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17508#discussion_r1767029629
More information about the hotspot-compiler-dev
mailing list