RFR: 8337221: CompileFramework: test library to conveniently compile java and jasm sources for fuzzing [v17]

[Emanuel Peter]

On Mon, 23 Sep 2024 08:51:58 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   another small suggestion from Christian
>
> Almost there, some minor nits left, mostly code style. Otherwise, looks good to me now!

@chhagedorn thanks for reviewing yet again! I addressed all your points.

> test/hotspot/jtreg/compiler/lib/compile_framework/CompileFramework.java line 48:
> 
>> 46:      * Set up a new Compile Framework instance, for a new compilation unit.
>> 47:      */
>> 48:     public CompileFramework() {}
> 
> You can probably omit that since it's empty.

I wanted to hava a javadoc string for the constructor though. Let me know if you think I should remove it.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20184#issuecomment-2368080856
PR Review Comment: https://git.openjdk.org/jdk/pull/20184#discussion_r1771315878