RFR: 8340602: C2: LoadNode::split_through_phi might exhaust nodes in case of base_is_phi [v2]

[Emanuel Peter]

On Tue, 24 Sep 2024 06:59:47 GMT, Daohan Qu <dqu at openjdk.org> wrote:

>> Daohan Qu has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>> 
>>   Check duplicate split in case of base_is_phi
>
> Hi @vnkozlov , I noticed that you have fixed a similar bug in [JDK-6673473](https://github.com/openjdk/jdk/commit/30dc0edfc877000c0ae20384f228b45ba82807b7). Could you please review this PR? Thanks a lot!

@quadhier just a drive-through comment: I think you need a regression test for this. Maybe using the whitebox api to see if the method got compiled, or if it was not compiled because not compilable?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21134#issuecomment-2371721777