RFR: 8320308: C2 compilation crashes in LibraryCallKit::inline_unsafe_access [v3]

Tobias Holenstein tholenstein at openjdk.org
Tue Sep 24 16:29:39 UTC 2024


On Tue, 24 Sep 2024 13:41:17 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Tobias Holenstein has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add another JTreg test with less flags
>
> test/hotspot/jtreg/compiler/parsing/TestUnsafeArrayAccessWithNullBase.java line 39:
> 
>> 37:  * @run main/othervm
>> 38:  * -Xbatch -XX:-TieredCompilation
>> 39:  * compiler.parsing.TestUnsafeArrayAccessWithNullBase
> 
> Not sure if there is a style-guide for writing JTREG commands... but I'd prefer if they were indented for every `@` command. With the second run, you could even drop `-Xbatch -XX:-TieredCompilation`, and just have `@run driver compiler.parsing.TestUnsafeArrayAccessWithNullBase`, because these 2 flags are also set from the ouside in some tiers, I think.

I changed the style and remove the flags.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20033#discussion_r1773677667


More information about the hotspot-compiler-dev mailing list