RFR: 8328528: C2 should optimize long-typed parallel iv in an int counted loop [v12]

Kangcheng Xu kxu at openjdk.org
Wed Sep 25 14:59:53 UTC 2024


On Wed, 25 Sep 2024 07:19:18 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>> Kangcheng Xu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   omit source BasicType
>
> src/hotspot/share/opto/loopnode.cpp line 4002:
> 
>> 4000:     // if stride_con2 is min_jint (or min_jlong, respectively) and
>> 4001:     // stride_con is -1.
>> 4002:     if (((stride_con2_bt == T_INT && stride_con2 == min_jint) ||
> 
> Can you use `min_signed_integer(BasicType bt)` here?

Good point! I wasn't aware of this helper. Thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18489#discussion_r1775402024


More information about the hotspot-compiler-dev mailing list