RFR: 8337679: Memset warning in src/hotspot/share/adlc/adlArena.cpp

[Julian Waters]

On Thu, 26 Sep 2024 09:16:11 GMT, Yagmur Eren <duke at openjdk.org> wrote:

> The purpose of this `memset` was to overwrite memory with garbage data before freeing it, helping detect bugs where the freed memory is accessed afterward. Therefore, removing it will no impact on functionality. Or it could be zapped with `memset_s` but zapping seems negligible in this case. It passes tier1 tests. See [JDK-8337679](https://bugs.openjdk.org/browse/JDK-8337679).

Hmm, wouldn't this make detecting bugs where memory is incorrectly accessed harder? (Seeing that's the purpose of this particular memset) Not sure if I'm missing anything here. Does the warning trigger if the memset is commented out?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21200#issuecomment-2376573780