RFR: 8320308: C2 compilation crashes in LibraryCallKit::inline_unsafe_access [v6]

[Tobias Holenstein]

On Wed, 25 Sep 2024 17:11:14 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Tobias Holenstein has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update test/hotspot/jtreg/compiler/parsing/TestUnsafeArrayAccessWithNullBase.java
>>   
>>   Co-authored-by: Tobias Hartmann <tobias.hartmann at oracle.com>
>
> src/hotspot/share/opto/library_call.cpp line 2367:
> 
>> 2365:   assert(!stopped(), "Inlining of unsafe access failed: address construction stopped unexpectedly");
>> 2366: 
>> 2367:   if (_gvn.type(base)->isa_ptr() == TypePtr::NULL_PTR) {
> 
> Why not `uncast` here?

makes sense to add here as well. Done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20033#discussion_r1777211788