RFR: 8325467: Support methods with many arguments in C2 [v6]

[Daniel Lundén]

On Thu, 26 Sep 2024 23:31:00 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Daniel Lundén has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains nine additional commits since the last revision:
>> 
>>  - Remove leftover debug var
>>  - Update
>>  - Merge tag 'jdk-24+16' into HEAD
>>    
>>    Added tag jdk-24+16 for changeset c58fbef0
>>  - Formatting updates
>>  - Update
>>  - Update after Roberto's comments and suggestions
>>  - Add can_represent asserts
>>  - Remove leftover CHUNK_SIZE reference
>>  - Support methods with many arguments in C2
>
> src/hotspot/share/opto/optoreg.hpp line 195:
> 
>> 193:   static constexpr bool can_fit(OptoReg::Name n) {
>> 194:     return n <= std::numeric_limits<Name>::max();
>> 195:   }
> 
> At first I thought this will always return true, but now I see it is checking OptoReg::Name against OptoRegPair::Name.

I'll make it explicit and write `return n <= std::numeric_limits<OptoRegPair::Name>::max();` to avoid confusion.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20404#discussion_r1778083391