RFR: 8320308: C2 compilation crashes in LibraryCallKit::inline_unsafe_access [v5]

Tobias Holenstein tholenstein at openjdk.org
Fri Sep 27 13:14:37 UTC 2024


On Wed, 25 Sep 2024 07:54:47 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Tobias Holenstein has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   JTreg style
>
> Looks good to me too.
> 
>> So it would make sense to go over the uses of Type*::BOTTOM/Type*::NOTNULL and check they are not tested with pointer equality
> 
> What about this concern? Did anyone check yet or should be file a follow-up task?

Thanks @TobiHartmann , @rwestrel , @eme64, @vnkozlov and @iwanowww for the reviews!

If @iwanowww is ok with the changes, this PR is ready to integrate. 

I will delegate since I am out of office the next 3 weeks.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20033#issuecomment-2379251776


More information about the hotspot-compiler-dev mailing list