RFR: 8348887: Create IR framework test for JDK-8347997

Galder Zamarreño galder at openjdk.org
Tue Apr 1 04:56:44 UTC 2025


On Mon, 31 Mar 2025 13:41:17 GMT, Marc Chevalier <mchevalier at openjdk.org> wrote:

> As the ticket says:
>> Create IR framework test which checks that allocations are eliminated in the regression test included in [JDK-8347997](https://bugs.openjdk.org/browse/JDK-8347997) fix.
> 
> So here it is! We can see that in case of inlining, indeed, no allocation happens. The second part is some sanity check to emphasize the difference: of course, there is an allocation without inlining. The benefit of this second part is arguable. From my point of view, it's mostly to point out the difference to a future reader. But yes, there is nothing very surprising.
> 
> Thanks,
> Marc

Changes requested by galder (Author).

test/hotspot/jtreg/compiler/c2/irTests/TestContinuationPinningAndEA.java line 118:

> 116: 
> 117:         @DontInline
> 118:         public CrashesNoInline() throws Throwable {

It's probably my own ignorance, but just in case are others are in the same boat, why does this crash? Could you add a brief javadoc for future readers? Same with other Crashes cases.

-------------

PR Review: https://git.openjdk.org/jdk/pull/24328#pullrequestreview-2731106771
PR Review Comment: https://git.openjdk.org/jdk/pull/24328#discussion_r2022140499


More information about the hotspot-compiler-dev mailing list