RFR: 8282053: IGV: refine schedule approximation
Roberto Castañeda Lozano
rcastanedalo at openjdk.org
Tue Apr 1 07:44:27 UTC 2025
On Tue, 1 Apr 2025 07:23:04 GMT, Daniel Skantz <dskantz at openjdk.org> wrote:
> This patch refines the schedule approximation in IGV by 1) placing parm. and projection nodes in the same block as their predecessors, and 2) disallows erroneously considering machine nodes such as prefetchAlloc and rep_stos as CFG nodes.
>
> The reader may refer to the corresponding JBS issue where graphs sampled before and after the change are attached.
>
> Testing: T1-T3 with no failures. Opened graphs before and after the change and saw no obvious problems. Opened a large number of graphs in CFG view and observed no unexpected IGV warnings, errors or assert failures.
Thanks for working on this, Daniel. Looks good!
-------------
Marked as reviewed by rcastanedalo (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24350#pullrequestreview-2731778708
More information about the hotspot-compiler-dev
mailing list