RFR: 8347645: C2: XOR bounded value handling blocks constant folding [v46]

[Emanuel Peter]

On Tue, 1 Apr 2025 02:49:45 GMT, Johannes Graham <duke at openjdk.org> wrote:

>> @iwanowww
>> 
>>> `_non_neg` part is confusing; I'd stress instead that it works on ranges.
>> 
>> I find it easier to think of it as calculating the upperbound of the xor of 2 non-negative integers whose upperbounds are given in the parameters.
>
> Renamed to `xor_upper_bound_for_ranges` before I saw your comment, @merykitty. I'd be ok with another name though. With the last changes, the method is no longer a member of the class, so it's no longer going to get as many eyes on it without context, so maybe it matters less now.

@j3graham I gave it a quick look, and it looks even better now. Let me run testing again before you integrate!

Please ping me in 24h for the results!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23089#issuecomment-2771441200