RFR: 8353359: C2: Or(I|L)Node::Ideal is missing AddNode::Ideal call

Wed Apr 2 07:32:08 UTC 2025

On Tue, 1 Apr 2025 06:20:48 GMT, Hannes Greule <hgreule at openjdk.org> wrote:

> Hi,
> 
> this simple change adds a missing AddNode::Ideal call to Or(I|L)Node::Ideal. See the added tests for examples of optimizations that don't apply without this change.
> 
> Please let me know what you think.

@SirYwell Wow, good find! Oh dear, things like this are so easy to get wrong. Thanks for writing the IR test, that seems really to be the only way to ensure we don't get these kinds of regressions. I wonder how many more of these kinds of issues we have... Optimal would be if we had IR tests for every optimization, but that would be a lot of work!

I'm running some testing, please ping me in 24h for the results!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24348#issuecomment-2771580262