RFR: 8353341: C2: removal of a Mod[DF]Node crashes when the node is already dead [v2]

[Marc Chevalier]

On Wed, 2 Apr 2025 07:27:04 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Marc Chevalier has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address review comments
>
> src/hotspot/share/opto/divnode.cpp line 1521:
> 
>> 1519: 
>> 1520:   bool result_is_unused = proj_out_or_null(TypeFunc::Parms) == nullptr;
>> 1521:   bool has_control_output = proj_out_or_null(TypeFunc::Control) != nullptr;
> 
> Nit: Maybe replace this with `is_dead = proj_out_or_null(TypeFunc::Control) == nullptr;` and check for `!is_dead` below?

Fine with me! At the very least, your name is more semantic, and less "here is a name that repeats what the code says".

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24375#discussion_r2024251731