RFR: 8352418: Add verification code to check that the associated loop nodes of useless Template Assertion Predicates are dead [v2]

[Christian Hagedorn]

On Wed, 2 Apr 2025 07:36:22 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Christian Hagedorn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add ResourceMark
>
> src/hotspot/share/opto/predicates.cpp line 1250:
> 
>> 1248: // graph (otherwise, they would have been marked useful instead). This is verified in this method.
>> 1249: void EliminateUselessPredicates::verify_loop_nodes_of_useless_templates_assertion_predicates_are_dead() const {
>> 1250:   Unique_Node_List loop_nodes_of_useless_template_assertion_predicates =
> 
> Should we add `ResourceMark` here, or is there one close by that suffices?

Good idea! I think the closest one will only be in `PhaseIdealLoop::optimize()` once we are done with one round of loop opts. So, it would make sense to add one here. Pushed an updated. Will ran some more testing to check that we don't hit any surprises.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24326#discussion_r2024263260